On 11/02/2025 14:29, Diederik de Haas wrote: > On Tue Feb 11, 2025 at 1:05 PM CET, Krzysztof Kozlowski wrote: >> On 11/02/2025 13:02, André Draszik wrote: >>> On Tue, 2025-02-11 at 11:57 +0000, Tudor Ambarus wrote: >>>> And then I shall s/MODULE_LICENSE("GPL");/MODULE_LICENSE("GPL v2");/ >>>> everywhere as "GPL" indicates [GNU Public License v2 or later]. >>> >>> No, please don't, see Documentation/process/license-rules.rst. >> For the rest of suggestions here I also recommend rereading docs. I >> don't get why we need to change "GPL-2.0 OR BSD-2-Clause", but maybe I >> miss some docs. Whatever SPDX recommends is irrelevant if kernel >> recommends for example something else, so be sure you make it aligned >> with actual kernel preference. > > Unfortunately, ``Documentation/process/license-rules.rst`` and > ``LICENSES/preferred/GPL-2.0`` are not in 'sync', but I guess that's > (potentially) a discussion for another ML. > > TL;DR: ``license-rules.rst`` says "GPL-2.0" while the license file > allows both. What exactly is there not in sync? To me it shows the preferred GPL-2.0, over GPL-2.0-only. LICENSES has licenses and all SPDX tags. license-rules for simplification uses only some and the ones there could be understood as preferred. Probably this should be changed first. Best regards, Krzysztof