On 21/01/2025 15:46, Peter Griffin wrote: >>> and eint_mask_offset for saving & restoring it's registers. >>> >>> Refactor the existing platform specific suspend/resume callback >>> so that each SoC variant has their own callback containing the >>> SoC specific logic. >>> >>> Additionally we now call drvdata->suspend() & drvdata->resume() >>> from within the loop that iterates the banks in >>> samsung_pinctrl_suspend() and samsung_pinctrl_resume(). >> >> Maybe split this patch in two: >> * first to do the refactoring plus adding exynosautov920_pinctrl_suspend() >> and exynosautov920_pinctrl_resume() >> * second to add gs101_pinctrl_suspend() / gs101_pinctrl_resume() >> >> This way, it's obvious which part is the bugfix and which part is the >> preparation and I believe it'd be easier to read. > > Sure, I will split it into two patches in the next version. > Yeah, ack. Best regards, Krzysztof
