On 20.12.2024 18:39, Dmitry Torokhov wrote: > On Fri, Dec 20, 2024 at 06:38:04PM +0100, Marek Szyprowski wrote: >> On 20.12.2024 18:22, Dmitry Torokhov wrote: >>> On Fri, Dec 20, 2024 at 01:36:59PM +0100, Marek Szyprowski wrote: >>>> On 07.11.2024 08:15, Dmitry Torokhov wrote: >>>>> Annotate allocated memory with __free(kfree) to simplify the code and >>>>> make sure memory is released appropriately. >>>>> >>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> >>>>> --- >>>>> drivers/input/ff-core.c | 19 ++++++------------- >>>>> 1 file changed, 6 insertions(+), 13 deletions(-) >>>> This patch landed in linux-next as commit 5203b3a18c1b ("Input: ff-core >>>> - make use of __free() cleanup facility"). In my tests I found that it >>>> causes the following kernel panic on some of my test boards. Reverting >>>> it, together with fd5ba0501d38 ("Input: ff-memless - make use of >>>> __free() cleanup facility") on top of next-20241220 fixes this panic >>>> issue. >>> Gah, I fixed this once and then undid it for some reason. I think the >>> following should fix the problem: >> Yep, this fixes the problem. Feel free to add: >> >> Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >> Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Thank you for the report and testing. Do you mind if I fold these fixes > into original patches? Go ahead, no problem for me. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland