On Tue, Dec 17, 2024 at 08:34:50AM +0000, André Draszik wrote: > On Tue, 2024-12-17 at 08:38 +0100, Krzysztof Kozlowski wrote: > > On Mon, Dec 16, 2024 at 01:06:28PM +0000, André Draszik wrote: > > > In order to support Pixel 6 (Oriole) and Pixel 6 Pro (Raven) properly, > > > we have to be able to distinguish them properly as we add support for > > > more features. > > > > > > For example, Raven has a larger display. There are other differences, > > > like battery design capacity, etc. > > > > > > Move all the parts that are common for now into a gs101-raviole.dtsi, > > > and just leave the display related things in gs101-oriole.dts. > > > > > > Raviole was chosen as the name because Google uses that when referring > > > to the combination of Oriole & Raven, keeping the familiar terminology. > > > > > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > > > > > > --- > > > Note: MAINTAINERS doesn't need updating, it covers this whole directory > > > --- > > > arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 290 +------------------- > > > .../boot/dts/exynos/google/gs101-raviole.dtsi | 297 +++++++++++++++++++++ > > > 2 files changed, 305 insertions(+), 282 deletions(-) > > > > > > > This looks like move of the code, so -M/-B/-C format patch arguments > > would create better diff. > > Ah, yes, forgot about those when I switched to using b4 instead of > custom scripts... If b4 does not do that by default, then it should set the option. One less thing to get right for users. I sent a patch for that. Rob
