On 18/12/2024 13:14, Peter Griffin wrote: > Hi André, > > On Mon, 16 Dec 2024 at 13:06, André Draszik <andre.draszik@xxxxxxxxxx> wrote: >> >> In order to support Pixel 6 (Oriole) and Pixel 6 Pro (Raven) properly, >> we have to be able to distinguish them properly as we add support for >> more features. >> >> For example, Raven has a larger display. There are other differences, >> like battery design capacity, etc. >> >> Move all the parts that are common for now into a gs101-raviole.dtsi, >> and just leave the display related things in gs101-oriole.dts. >> >> Raviole was chosen as the name because Google uses that when referring >> to the combination of Oriole & Raven, keeping the familiar terminology. > > As discussed off list lets not use the "raviole" terminology (as it > precludes Pixel 6a / Bluejay which is also based on gs101). I think > something like gs101-board-common.dtsi would be better. gs101 is a SoC not a phone and you need here something common for boards. Choose whatever name you like, but there should be a name (so gs101-foo-common). Best regards, Krzysztof
