On Fri, 13 Dec 2024 16:44:39 +0000, Peter Griffin wrote: > To avoid dtschema warnings allow google,gs101-pmu to have > two reg regions. > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > --- > I don't really like this patch, but also didn't want to submit the series > with a dtschema warning ;-) > > Possibly a better solution is when Robs patch > `mfd: syscon: Allow syscon nodes without a "syscon" compatible` [1] > > gets updated with a v2, we could remove syscon compatible from > gs101.dtsi (an ABI issue). If I understood his patch correctly, > it would mean this yaml update would then no longer be required. > > Let me know your thoughts > > [1] https://lore.kernel.org/lkml/20241211-syscon-fixes-v1-0-b5ac8c219e96@xxxxxxxxxx/T/#m5ad1ed5c69f693d2a5cc54342a87fbdf3df756d2 > --- > Documentation/devicetree/bindings/mfd/syscon-common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: [error] syntax error: expected <block end>, but found '?' (syntax) ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:69:5: [warning] wrong indentation: expected 6 but found 4 (indentation) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/syscon-common.yaml: ignoring, error parsing file make[2]: *** Deleting file 'Documentation/devicetree/bindings/mfd/syscon-common.example.dts' Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: expected <block end>, but found '?' make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/mfd/syscon-common.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/mfd/syscon-common.yaml:68:3: expected <block end>, but found '?' make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241213-contrib-pg-cpu-hotplug-suspend2ram-fixes-v1-v1-2-c72978f63713@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
