Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Monday, December 9, 2024 1:04 PM
> To: Faraz Ata <faraz.ata@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; krzk+dt@xxxxxxxxxx; robh@xxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> rosa.pila@xxxxxxxxxxx
> Subject: Re: [PATCH] arm64: dts: exynosautov920: add DMA nodes
>
> On 04/12/2024 13:23, Faraz Ata wrote:
> > +
> > + spdma1: dma-controller@10190000 {
> > + compatible = "arm,pl330", "arm,primecell";
> > + reg = <0x10190000 0x1000>;
> > + interrupts = <GIC_SPI 917 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cmu_misc
> CLK_MOUT_MISC_NOC_USER>;
> > + clock-names = "apb_pclk";
> > + #dma-cells = <1>;
> > + };
> > +
> > + pdma0: dma-controller@101A0000 {
>
> Please do not send downstream code directly, but fix it to match upstream.
> Lowercase hex everywhere.
>
Thanks for your review, will takecare in future patches.
> Best regards,
> Krzysztof
