On Mon, Dec 02, 2024 at 01:06:09PM +0100, Maxime Ripard wrote: > Hi, > > On Sun, Dec 01, 2024 at 02:44:06AM +0200, Dmitry Baryshkov wrote: > > The no_capture_mute flag might differ from platform to platform, > > especially in the case of the wrapping implementations, like the > > upcoming DRM HDMI Codec framework. Move the flag next to all other flags > > in struct hdmi_codec_pdata. > > > > Acked-by: Mark Brown <broonie@xxxxxxxxxx> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > I appreciate it might be a dumb question, but I never really understood > what no_capture_mute was all about. And in that context, why some > drivers would need / use it, and some won't. Some platforms can not mute the HDMI capture (ARC?) path. See the following patches: - https://lore.kernel.org/all/1606372608-2329-1-git-send-email-shengjiu.wang@xxxxxxx/ - https://lore.kernel.org/all/1606372608-2329-1-git-send-email-shengjiu.wang@xxxxxxx/ Russell added a way to disable capture / playback support, but only TDA driver uses those. I think generally we should change those flags to be opt-in for capture, but that requires carefully reviewing all the platforms (and is a separate topic anyway). -- With best wishes Dmitry
