On 02/12/2024 14:07, Thomas Antoine via B4 Relay wrote: > From: Thomas Antoine <t.antoine@xxxxxxxxxxxx> > > As the Maxim max77759 fuel gauge has no non-volatile memory slave address, s/max77759/MAX77759/ Please explain the device in general, e.g. fuel gauge is only one part of the PMIC chip. Otherwise 'fg' compatible suffix would not be justified. > make it non-obligatory. Except for this, the max77759 seems to behave the > same as the max1720x. > > Signed-off-by: Thomas Antoine <t.antoine@xxxxxxxxxxxx> > --- > .../devicetree/bindings/power/supply/maxim,max17201.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml > index fe3dd9bd5585618e45220c51023391a5b21acfd2..417fc2c4a1c1961654bc54ec1ac24602012f3335 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml > @@ -16,6 +16,7 @@ properties: > compatible: > oneOf: > - const: maxim,max17201 > + - const: maxim,max77759-fg > - items: > - enum: > - maxim,max17205 > @@ -25,11 +26,13 @@ properties: > items: > - description: ModelGauge m5 registers > - description: Nonvolatile registers > + minItems: 1 > > reg-names: > items: > - const: m5 > - const: nvmem > + minItems: 1 You need allOf:if:then section narrowing it per each variant. > > interrupts: > maxItems: 1 > @@ -56,3 +59,14 @@ examples: > interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > }; > }; > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fuel-gauge@36 { > + compatible = "maxim,max77759-fg"; No need for new example if it differs with one property. Best regards, Krzysztof