On 28/11/2024 09:34, André Draszik wrote: > On Thu, 2024-11-28 at 09:21 +0100, Krzysztof Kozlowski wrote: >> On 27/11/2024 12:01, André Draszik wrote: >>> When the serial console is enabled, we need to disable power delivery >>> since serial uses the SBU1/2 pins and appears to confuse the TCPCI, >>> resulting in endless interrupts. >>> >>> For now, change the DT such that the serial console continues working. >>> >>> Note1: We can not have both typec-power-opmode and >>> new-source-frs-typec-current active at the same time, as otherwise DT >>> binding checks complain. >>> >>> Note2: When using a downstream DT, the Pixel boot-loader will modify >>> the DT accordingly before boot, but for this upstream DT it doesn't >>> know where to find the TCPCI node. The intention is for this commit to >>> be reverted once an updated Pixel boot-loader becomes available. >>> >>> Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> >> >> This should be squashed to the previous patch, including also combining >> commit messages. > > I contemplated that, but I didn't in the end so that it's easy to just > revert this specific patch once the boot loader is updated. > > I would prefer to keep them as separate patches for that reason, but will > squash if you still think that's better. > OK, can be separate. Best regards, Krzysztof
