On Mon, 2024-11-11 at 23:18 +0530, Manivannan Sadhasivam via B4 Relay wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > When the UFSHCD platform glue drivers are removed, runtime PM should > be > disabled using pm_runtime_disable() to balance the enablement done in > ufshcd_pltfrm_init(). This is also reported by PM core when the glue > driver > is removed and inserted again: > > ufshcd-qcom 1d84000.ufshc: Unbalanced pm_runtime_enable! > > So disable runtime PM using a new helper API ufshcd_pltfrm_remove(), > that > also takes care of removing ufshcd. This helper should be called > during the > remove() stage of glue drivers. > > Cc: stable@xxxxxxxxxxxxxxx # 3.12 > Fixes: 62694735ca95 ("[SCSI] ufs: Add runtime PM support for UFS host > controller driver") > Signed-off-by: Manivannan Sadhasivam < > manivannan.sadhasivam@xxxxxxxxxx> > --- > drivers/ufs/host/cdns-pltfrm.c | 4 +--- > drivers/ufs/host/tc-dwc-g210-pltfrm.c | 4 +--- > drivers/ufs/host/ufs-exynos.c | 2 +- > drivers/ufs/host/ufs-hisi.c | 4 +--- > drivers/ufs/host/ufs-mediatek.c | 4 +--- > drivers/ufs/host/ufs-qcom.c | 2 +- > drivers/ufs/host/ufs-renesas.c | 4 +--- > drivers/ufs/host/ufs-sprd.c | 4 +--- > drivers/ufs/host/ufshcd-pltfrm.c | 13 +++++++++++++ > drivers/ufs/host/ufshcd-pltfrm.h | 1 + > 10 files changed, 22 insertions(+), 20 deletions(-) > > Reviewed-by: Peter Wang <peter.wang@xxxxxxxxxxxx>