On 10/21/24 5:47 PM, Alim Akhtar wrote: > Hi Tudor Hi, Alim! Thanks for the review! >> diff --git a/drivers/firmware/samsung/Kconfig >> b/drivers/firmware/samsung/Kconfig >> new file mode 100644 >> index 000000000000..f908773c1441 >> --- /dev/null >> +++ b/drivers/firmware/samsung/Kconfig >> @@ -0,0 +1,11 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> + >> +config EXYNOS_ACPM > > This looks misleading to me, as you mentioned below, ACPM is a FW which runs > on APM module, and > The proposed driver is a communication method between Application processor > and APM module, > Which is via MAILBOX. > So preferably EXYNOS_MAILBOX_APM is more meaningful here. This seems more accurate indeed. The design document that I have refers to the protocol as "ACPM IPC", so maybe I shall stick with EXYNOS_ACPM_IPC. I'll also need to prefix all the definitions in the driver with exynos_acpm_ipc_* which will result in long names. But I guess there's nothing we can do about it. Cheers, ta
