On 18/10/2024 08:48, Umer Uddin wrote: > On Thu, Oct 17, 2024 at 05:43:27PM +0100, Umer Uddin wrote: >>> Add initial support for the Samsung Galaxy S20 (x1slte/SM-G980F) >>> phone. It was launched in 2020, and it's based on the Exynos 990 SoC. It >>> has only one configuration with 8GB of RAM and 128GB of UFS 3.0 storage. > >> 8 GB RAM, so the memory map should not be the same (and should not be in >> DTSI file). > >>> >>> This device tree adds support for the following: >>> >>> - SimpleFB >>> - 8GB RAM >>> - Buttons > > Best regards, > Krzysztof > > Hi Krzysztof, > > Thank you for the review. > All hubble devices actually do > have the first 8GB of RAM mapped the same, I have personally > checked this, by getting fdt dumps from /sys/firmware/fdt > and checking all of the memory nodes. > What about remaining 4 GB on X1S? Best regards, Krzysztof