Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: Monday, September 30, 2024 8:36 PM > To: Sunyeal Hong <sunyeal.hong@xxxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Sylwester > Nawrocki <s.nawrocki@xxxxxxxxxxx>; Chanwoo Choi <cw00.choi@xxxxxxxxxxx>; > Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd > <sboyd@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- > clk@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/3] clk: samsung: exynosautov920: add peric1, misc > and hsi0/1 clock support > > On 12/09/2024 12:38, Sunyeal Hong wrote: > > Like CMU_PERIC1, this provides clocks for USI09 ~ USI17, USI_I2C and > USI_I3C. > > Like CMU_MISC, this provides clocks for MISC, GIC and OTP. > > Like CMU_HSI0, this provides clocks for PCIE. > > Like CMU_HSI1, this provides clocks for USB and MMC. > > > > Signed-off-by: Sunyeal Hong <sunyeal.hong@xxxxxxxxxxx> > > --- > > ... > > > + > > static int __init exynosautov920_cmu_probe(struct platform_device > > *pdev) { > > const struct samsung_cmu_info *info; @@ -1154,6 +1431,19 @@ static > > const struct of_device_id exynosautov920_cmu_of_match[] = { > > { > > .compatible = "samsung,exynosautov920-cmu-peric0", > > .data = &peric0_cmu_info, > > + }, { > > + .compatible = "samsung,exynosautov920-cmu-peric1", > > + .data = &peric1_cmu_info, > > + }, { > > + .compatible = "samsung,exynosautov920-cmu-misc", > > + .data = &misc_cmu_info, > > + }, { > > + .compatible = "samsung,exynosautov920-cmu-hsi0", > > + .data = &hsi0_cmu_info, > > + }, { > > + .compatible = "samsung,exynosautov920-cmu-hsi1", > > + .data = &hsi1_cmu_info, > > + }, { > > This is unrelated change. Please rebase. > Could you please explain in more detail the comment mentioned above? Best Regards, sunyeal > Best regards, > Krzysztof >