Re: [PATCH v4 08/10] ARM: dts: samsung: exynos4212-tab3: Add battery node with charge current value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Aug 16, 2024 at 12:03:32PM GMT, Krzysztof Kozlowski wrote:
> On 16/08/2024 10:19, Artur Weber wrote:
> > This value was verified by comparing register dumps of the MAX77693
> > charger with on mainline with a downstream kernel under Android; the
> > value on downstream was set to 1.8 amps when charging with a proper
> > charger.
> > 
> > Add it to a new battery node and pass it to the MAX77693 charger
> > so that the fast charge current setting can be used for charging.
> > 
> > Tested-by: Henrik Grimler <henrik@xxxxxxxxxx>
> > Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - Switched to monitored-battery
> > ---
> >  arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> For next version, please split DTS into separate patchset and provide in
> changelog (---) lore link to power supply patchset with bindings. It
> will be easier for Sebastian to apply entire set for psy.

I'm fine with a splitted series of course, but I am also perfectly
fine with applying partial patchsets. I know at least some SoC
maintainers like this style of a combined patch series, since they
basically get an automatic push notification that the dependencies
have been merged. It also makes testing easier of course :)

-- Sebastian

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux for Synopsys ARC Processors]    
  • [Linux on Unisoc (RDA Micro) SoCs]     [Linux Actions SoC]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  •   Powered by Linux