Hi,
On at least two plaforms, i.MX and the Exynos-derivative gs101,
earlycon depends on the bootloader setup stdout clocks being retained.
In some cases stdout UART clocks (or their parents) can get disabled
during loading of other drivers (e.g. i2c or UART driver init) causing
earlycon to stop to work sometime into the boot, halting the whole
system, see e.g. [3].
Code exists in the i.MX clock drivers to deal with that by temporarily
bumping the reference count of the relevant stdout clocks during early
boot.
While gs101 doesn't have such code, some UART clocks had been marked
'critical' for a different reason originally, and by accident
worked-around the same problem. v4 of this series proposed addition of
similar code to gs101 to be able to drop the 'critical' flag from its
clocks, but Stephen suggested to move all this into the clk core
instead.
This series now does that:
* instead of duplicating such code to gs101, teaches the clk core to
deal with stdout clocks during early boot, similar to the existing
support in i.MX
This is hooked into of_clk_add_hw_provider() and
of_clk_add_provider()
* updates gs101 to remove the 'critical' flag from affected clocks, as
not necessary. This is essentially the last remaining patch [1] with
all review comments addressed, from the series [2] that was sent
earlier this year, see lore links below.
* updates i.MX to remove the now-unnecessary platform specific code in
its clock drivers. I believe this also plugs a memory and extra clock
reference leak at least on imx7ulp, see below.
Note 1: For the avoidance of doubt, any of the above is relevant only
if earlycon and OF are enabled, behaviour is based on the
'earlycon' kernel command line parameter.
As this is meant to also replace i.MX specific code, the
'earlyprintk' is also supported (since it was supported on
i.MX)
Note 2: On i.MX, at least clk-imx7ulp.c calls
imx_register_uart_clocks() twice (once for each compatible),
but imx_register_uart_clocks() can not handle that and will
leak memory and clock references in that case.
The new clk core code handles multiple invocations without such
issues.
Note 3: I am not in a position to test any of the i.MX changes and
would appreciate feedback. In particular with these changes
stdout clocks are enabled when of_clk_add_hw_provider() or
of_clk_add_provider() return, but:
* some i.MX platforms did some reparenting or frequency changes
in the old approach before enabling stdout clocks. I believe
they're all unrelated to stdout, though
* some i.MX platforms enabled stdout clocks before the call to
of_clk_add_hw_provider() or of_clk_add_provider(). Again, I
don't think that difference is going to be relevant.
Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
[1] https://lore.kernel.org/all/20240130093812.1746512-6-andre.draszik@xxxxxxxxxx/
[2] https://lore.kernel.org/all/20240130093812.1746512-1-andre.draszik@xxxxxxxxxx/
[3] https://lore.kernel.org/all/d45de3b2bb6b48653842cf1f74e58889ed6783ae.camel@xxxxxxxxxx/
Changes in v6:
- drop a stray #include from drivers/clk/samsung/clk-gs101.c
- Link to v5: https://lore.kernel.org/r/20240808-gs101-non-essential-clocks-2-v5-0-11cffef0634e@xxxxxxxxxx
Changes in v5:
- move stdout uart clock handling from gs101 into clk core (Stephen)
- update i.MX to drop now-unnecessary code
- update series' subject due to changed scope
- Link to v4: https://lore.kernel.org/r/20240712-gs101-non-essential-clocks-2-v4-0-310aee0de46e@xxxxxxxxxx
Changes in v4:
- new patch "clk: samsung: gs101: allow earlycon to work unconditionally"
- update commit message for patch 2
- Link to v3: https://lore.kernel.org/r/20240710-gs101-non-essential-clocks-2-v3-0-5dcb8d040d1c@xxxxxxxxxx
---
André Draszik (20):
clk: bump stdout clock usage for earlycon
clk: samsung: gs101: don't mark non-essential (UART) clocks critical
clk: imx: imx25: drop call to imx_register_uart_clocks()
clk: imx: imx27: drop call to imx_register_uart_clocks()
clk: imx: imx35: drop call to imx_register_uart_clocks()
clk: imx: imx5: drop call to imx_register_uart_clocks()
clk: imx: imx6q: drop call to imx_register_uart_clocks()
clk: imx: imx6sl: drop call to imx_register_uart_clocks()
clk: imx: imx6sll: drop call to imx_register_uart_clocks()
clk: imx: imx6sx: drop call to imx_register_uart_clocks()
clk: imx: imx6ul: drop call to imx_register_uart_clocks()
clk: imx: imx7d: drop call to imx_register_uart_clocks()
clk: imx: imx7ulp: drop calls to imx_register_uart_clocks()
clk: imx: imx8mm: drop call to imx_register_uart_clocks()
clk: imx: imx8mn: drop call to imx_register_uart_clocks()
clk: imx: imx8mp: drop call to imx_register_uart_clocks()
clk: imx: imx8mq: drop call to imx_register_uart_clocks()
clk: imx: imx8ulp: drop call to imx_register_uart_clocks()
clk: imx: imx93: drop call to imx_register_uart_clocks()
clk: imx: drop imx_register_uart_clocks()
drivers/clk/clk.c | 129 ++++++++++++++++++++++++++++++++++++++++
drivers/clk/imx/clk-imx25.c | 2 -
drivers/clk/imx/clk-imx27.c | 2 -
drivers/clk/imx/clk-imx35.c | 2 -
drivers/clk/imx/clk-imx5.c | 6 --
drivers/clk/imx/clk-imx6q.c | 2 -
drivers/clk/imx/clk-imx6sl.c | 2 -
drivers/clk/imx/clk-imx6sll.c | 2 -
drivers/clk/imx/clk-imx6sx.c | 2 -
drivers/clk/imx/clk-imx6ul.c | 2 -
drivers/clk/imx/clk-imx7d.c | 2 -
drivers/clk/imx/clk-imx7ulp.c | 4 --
drivers/clk/imx/clk-imx8mm.c | 2 -
drivers/clk/imx/clk-imx8mn.c | 2 -
drivers/clk/imx/clk-imx8mp.c | 2 -
drivers/clk/imx/clk-imx8mq.c | 2 -
drivers/clk/imx/clk-imx8ulp.c | 2 -
drivers/clk/imx/clk-imx93.c | 2 -
drivers/clk/imx/clk.c | 72 ----------------------
drivers/clk/imx/clk.h | 7 ---
drivers/clk/samsung/clk-gs101.c | 6 +-
21 files changed, 131 insertions(+), 123 deletions(-)
---
base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
change-id: 20240430-gs101-non-essential-clocks-2-6a3280fa1be8
Best regards,
--
André Draszik <andre.draszik@xxxxxxxxxx>
