> -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: 01 August 2024 05:48 > To: Swathi K S <swathi.ks@xxxxxxxxxxx> > Cc: krzk@xxxxxxxxxx; robh@xxxxxxxxxx; davem@xxxxxxxxxxxxx; > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; richardcochran@xxxxxxxxx; > mcoquelin.stm32@xxxxxxxxx; alim.akhtar@xxxxxxxxxxx; linux- > fsd@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; linux- > arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; > alexandre.torgue@xxxxxxxxxxx; peppe.cavallaro@xxxxxx; > joabreu@xxxxxxxxxxxx; rcsekar@xxxxxxxxxxx; ssiddha@xxxxxxxxx; > jayati.sahu@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; > ravi.patel@xxxxxxxxxxx; gost.dev@xxxxxxxxxxx > Subject: Re: [PATCH v4 3/4] arm64: dts: fsd: Add Ethernet support for FSYS0 > Block of FSD SoC > > > > What is the interface connected to? A switch? > > > > Hi Andrew, > > Thanks for the quick review. AFAIK, this has been discussed earlier. I > > am providing the links to the same here for quick reference. > > > > [1] > > https://protect2.fireeye.com/v1/url?k=137f9a1c-72027264-137e1153-74fe4 > > 85fffb1-6e7bf5aa53b8cc75&q=1&e=46ff39bb-87c6-4b24-9cee- > a6ed900a5b7f&u= > > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F7%2F29%2F419 > > [2] > > https://protect2.fireeye.com/v1/url?k=dca2820d-bddf6a75-dca30942-74fe4 > > 85fffb1-9b7f4695da0bf0b8&q=1&e=46ff39bb-87c6-4b24-9cee- > a6ed900a5b7f&u= > > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F6%2F6%2F817 > > [3] > > https://protect2.fireeye.com/v1/url?k=552d5dcd-3450b5b5-552cd682-74fe4 > > 85fffb1-3bb7c6c469af30f5&q=1&e=46ff39bb-87c6-4b24-9cee- > a6ed900a5b7f&u= > > https%3A%2F%2Flkml.org%2Flkml%2F2024%2F6%2F6%2F507 > > [4] > > https://protect2.fireeye.com/v1/url?k=c613c4f6-a76e2c8e-c6124fb9-74fe4 > > 85fffb1-469219b2dcdd3e0e&q=1&e=46ff39bb-87c6-4b24-9cee- > a6ed900a5b7f&u= > > https%3A%2F%2Flkml.org%2Flkml%2F2023%2F8%2F14%2F1341 > > > > Please let us know if you have any further queries on this. > > Ah, O.K. > > It would make sense to add to the commit message something like: > > The Ethernet interface is connected to a switch, which Linux is not managing. Thanks for the suggestion and it makes sense. Will update the commit message this way in the next version. > > Part of the purpose of the commit message is to answer questions reviewers > might have. This is one such question. > > Andrew Regards, Swathi
