On Wed, Jul 31, 2024 at 4:14 PM Mateusz Majewski <m.majewski2@xxxxxxxxxxx> wrote: > > > Do I understand it correctly that the patch actually removes an > > outdated description of *driver* implementation, and not outdated > > hardware description? > > Correct. > > > If so, then maybe it makes sense to rework the > > patch title and commit message in a way Rob suggests. I.e. rather than > > stating that the patch removes an outdated information, instead > > mention it removes *software* (driver) description which was > > incorrectly added earlier. Because bindings are only meant for > > hardware description and should be completely independent of driver's > > side of things. Also in that case it probably doesn't make much sense > > referencing that commit for using set_trips ops. Just my two cents. > > Makes sense, what do you think about this? > > dt-bindings: thermal: samsung,exynos: remove driver-specific information > > The number of supported trip points was only limited by the driver > implementation at the time, which mapped each trip point defined in the > devicetree source file to a hardware trip point. An implementation that > does not have this limitation is possible; indeed, that is how the > driver works currently. Therefore, this information should be removed > from the bindings description, which are meant to be independent from > the details of the driver implementation. Looks good to me. But you already have my R-b tag :) More important if it's ok with Rob.
