On 22/07/2024 08:26, Krzysztof Kozlowski wrote: > On 18/07/2024 14:20, Artur Weber wrote: >> On 10.05.2024 08:59, Marek Szyprowski wrote: >>> Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating >>> clkdev entries") revealed that clock lookup is registered for all fixed >>> clocks. The mentioned commit added a check if the registered name is not >>> too long. This fails for some clocks registered for Exynos542x SoCs family. >>> This lookup is a left-over from early common clock framework days, not >>> really needed nowadays, so remove it to avoid further issues. >> >> This commit causes a warning to appear during startup on Exynos 4x12:> >> > [ 0.000000] exynos4_clk_register_finpll: failed to lookup parent clock xusbxti, assuming fin_pll clock frequency is 24MHz >> > [ 0.000000] Exynos4x12 clocks: sclk_apll = 400000000, sclk_mpll = 800000000 >> > sclk_epll = 96000000, sclk_vpll = 108000000, arm_clk = 800000000 >> >> The warning seems to come from exynos4_clk_register_finpll in >> drivers/clk/samsung/clk-exynos4.c, where clk_get fails with error code -2. > > > Indeed, so clk_hw_register_clkdev() was needed for clk_get(). I have a > fix for this. ... and of course thanks for the report! Best regards, Krzysztof