Hi André, On Tue, 7 May 2024 at 15:14, André Draszik <andre.draszik@xxxxxxxxxx> wrote: > > Using 0x82 seems odd, where everything else is just a sequence. > > On E850, this macro isn't used (as a register value), only to assign > its value to the 'extrefclk' variable, which is otherwise unused on > that platform. Older platforms don't appear to support 26MHz in the > first place (since this macro was added for E850). > > Furthermore, the downstream driver uses 0x82 to denote > USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the > other values we match downstream's non-DIFF macros. > > Update to avoid confusion. No functional change intended. > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > --- Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx> regards, Peter [..]
