Hi Chanwoo
On Wed, 8 May 2024 at 21:16, Chanwoo Choi <chanwoo@xxxxxxxxxx> wrote:
>
> On Wed, Apr 17, 2024 at 1:45 PM Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> >
> > The devm_clk_get_enabled() helpers:
> > - call devm_clk_get()
> > - call clk_prepare_enable() and register what is needed in order to
> > call clk_disable_unprepare() when needed, as a managed resource.
> >
> > This simplifies the code and avoids the calls to clk_disable_unprepare().
> >
> > While at it, use dev_err_probe consistently, and use its return value
> > to return the error code.
> >
> > Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>
> > ---
> > v3 - No change
> > v2 - No change
> > ---
> > drivers/devfreq/exynos-bus.c | 21 ++++-----------------
> > 1 file changed, 4 insertions(+), 17 deletions(-)
> >
> > diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> > index 245898f1a88e..153340b6685f 100644
> > --- a/drivers/devfreq/exynos-bus.c
> > +++ b/drivers/devfreq/exynos-bus.c
> > @@ -160,7 +160,6 @@ static void exynos_bus_exit(struct device *dev)
> > platform_device_unregister(bus->icc_pdev);
> >
> > dev_pm_opp_of_remove_table(dev);
> > - clk_disable_unprepare(bus->clk);
> > dev_pm_opp_put_regulators(bus->opp_token);
> > }
> >
> > @@ -171,7 +170,6 @@ static void exynos_bus_passive_exit(struct device *dev)
> > platform_device_unregister(bus->icc_pdev);
> >
> > dev_pm_opp_of_remove_table(dev);
> > - clk_disable_unprepare(bus->clk);
> > }
> >
> > static int exynos_bus_parent_parse_of(struct device_node *np,
> > @@ -247,23 +245,15 @@ static int exynos_bus_parse_of(struct device_node *np,
> > int ret;
> >
> > /* Get the clock to provide each bus with source clock */
> > - bus->clk = devm_clk_get(dev, "bus");
> > - if (IS_ERR(bus->clk)) {
> > - dev_err(dev, "failed to get bus clock\n");
> > - return PTR_ERR(bus->clk);
> > - }
> > -
> > - ret = clk_prepare_enable(bus->clk);
> > - if (ret < 0) {
> > - dev_err(dev, "failed to get enable clock\n");
> > - return ret;
> > - }
> > + bus->clk = devm_clk_get_enabled(dev, "bus");
> > + if (IS_ERR(bus->clk))
> > + return dev_err_probe(dev, PTR_ERR(bus->clk), "failed to get bus clock\n");
>
> nitpick. I recommend that better to keep 80 char on one line as following
> for the readability.
>
> return dev_err_probe(dev, PTR_ERR(bus->clk),
> "failed to get bus clock\n");
>
Ok
>
I will update this in the next version.
Thanks
-Anand
