On 04/09/2024, Krzysztof Kozlowski wrote: > On 09/04/2024 22:22, Will McVicker wrote: > > Export the module alias information using the MODULE_DEVICE_TABLE() > > macro in order to support auto-loading this module for devices that > > support it. > > > > $ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko > > of:N*T*Ctesla,fsd-ufsC* > > of:N*T*Ctesla,fsd-ufs > > of:N*T*Csamsung,exynosautov9-ufs-vhC* > > of:N*T*Csamsung,exynosautov9-ufs-vh > > of:N*T*Csamsung,exynosautov9-ufsC* > > of:N*T*Csamsung,exynosautov9-ufs > > of:N*T*Csamsung,exynos7-ufsC* > > of:N*T*Csamsung,exynos7-ufs > > That part is redundant, you just copied result of of_device_id. No need > to resend just for this. Well the point of including this snippet is to show that it's working. Without this patch, `modinfo -F alias ufs-exynos.ko` doesn't return anything. I'm fine with not including it either way though. Thanks, Will > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof >