On 22/03/2024 14:39, Tudor Ambarus wrote: >> >>> + #address-cells = <1>; >>> + #size-cells = <0>; > > I'd like to respin this patch. Any preference on coding style for > #address-cells and #size-cells? I guess they shall be above ranges > property if present. No, ranges should be just after reg, because it encodes often the same or similar information (see also DTS Coding Style). I don't have guideline, can be anywhere before vendor properties. > >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&hsi2c1_bus>; >> >> Please reverse two lines, first pinctrl-0 then pinctrl-names. I know we > > Ok. > >> did not follow this convention till now, but at least new code can be >> correct. Also clocks should be before pinctrl, so we keep some sort of >> alphabetical order. > > Ok. > > I guess the order shall be: > > 1. compatible > 2. reg 3. ranges > 3. #address-cells (if applicable) > #size-cells (if applicable) > 5. Standard/common properties ordered alphabetically (ex. clocks, > interrupts, pinctrl) > 6. vendor-specific properties > 7. status (if applicable) > Rest looks fine, thanks. Best regards, Krzysztof
