On Tue, Mar 05, 2024 at 10:53:13AM +0100, Andi Shyti wrote:
> Hi Jesper,
Hi Andi,
> I have taken your patch in my testing branch, but...
>
> > + /* Clear pending interrupts from u-boot or misc causes */
> > + exynos5_i2c_clr_pend_irq(i2c);
> > +
> > + i2c->irq = ret = platform_get_irq(pdev, 0);
>
> ... I get this checkpatch note:
>
> CHECK: multiple assignments should be avoided
> #60: FILE: drivers/i2c/busses/i2c-exynos5.c:932:
> + i2c->irq = ret = platform_get_irq(pdev, 0);
Hm, that's weird, I did run checkpatch and got no notices about that.
Ah, it looks like you're running with --strict to checkpatch.
> You are still in time to fix it, or you can fix it later or you
> can leave it as for me it's not a big deal.
No problem, v3 coming soon.
> But, please, next time, make sure to run checkpatch before
> sending a patch.
Yup. I'll run with --strict also in the future.
> Thanks,
> Andi
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
