On 16/02/2024 23:32, Sam Protsenko wrote:
> Make it more obvious which register layout should be used for a CPU
> clock. It prepares clk-cpu.c for adding new chips support.
>
> No functional change.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> ---
> drivers/clk/samsung/clk-cpu.c | 2 +-
> drivers/clk/samsung/clk-cpu.h | 12 ++++++++++--
> drivers/clk/samsung/clk-exynos3250.c | 2 +-
> drivers/clk/samsung/clk-exynos4.c | 6 +++---
> drivers/clk/samsung/clk-exynos5250.c | 3 ++-
> drivers/clk/samsung/clk-exynos5420.c | 8 ++++----
> drivers/clk/samsung/clk-exynos5433.c | 8 ++++----
> drivers/clk/samsung/clk.h | 4 +++-
> 8 files changed, 28 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c
> index 4c46416281a3..21998c89b96d 100644
> --- a/drivers/clk/samsung/clk-cpu.c
> +++ b/drivers/clk/samsung/clk-cpu.c
> @@ -464,7 +464,7 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx,
> cpuclk->lock = &ctx->lock;
> cpuclk->flags = clk_data->flags;
> cpuclk->clk_nb.notifier_call = exynos_cpuclk_notifier_cb;
> - if (clk_data->flags & CLK_CPU_HAS_E5433_REGS_LAYOUT) {
> + if (clk_data->reg_layout == CPUCLK_LAYOUT_E5433) {
Why flags cannot work for it and we need one more property? The point of
flags is to customize the variant entirely. You basically split now
flags into flags A and flags B.
Best regards,
Krzysztof
