> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: 30 January 2024 19:57 > To: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Cc: m.szyprowski@xxxxxxxxxxx; andrzej.hajda@xxxxxxxxx; > mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > conor+dt@xxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; > andi@xxxxxxxxxxx; gost.dev@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx > Subject: Re: [PATCH] dt-bindings: media: s5p-mfc: Remove s5p-mfc.txt > binding > > On 30/01/2024 15:25, Krzysztof Kozlowski wrote: > > On 30/01/2024 13:57, Aakarsh Jain wrote: > >> Commit "538af6e5856b" which convert s5p-mfc bindings to > > > > Please run scripts/checkpatch.pl and fix reported warnings. Some > > warnings can be ignored, but the code here looks like it needs a fix. > > Feel free to get in touch if the warning is not clear. > > I am getting below warning while running scripts/checkpatch.pl on this patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: deleted file mode 100644 total: 0 errors, 1 warnings, 0 lines checked I think this can be ignored. > >> json-schema is already merged. Remove "s5p-mfc.txt" file. > >> > >> Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/media/s5p-mfc.txt | 0 > > > > Why you did not remove it in the first place? Your diff from > > 538af6e5856b is so confusing. > I missed it before. Will add Fixes tag. > Also, add fixes tag. > Sure. Thanks for review! > Best regards, > Krzysztof
