Hi Sam, On Fri, 2024-01-26 at 21:00 -0600, Sam Protsenko wrote: > On Fri, Jan 26, 2024 at 6:19 PM André Draszik <andre.draszik@xxxxxxxxxx> wrote: > > > > Without the clock running, we can not access its registers, and now > > that we have it, we should add it here so that it gets enabled as > > and when needed. > > > > That sounds like this patch deserves "Fixes:" tag :) Other than that: I didn't add it, because at the time &sysreg_peric1 was added, the clock macro CLK_GOUT_PERIC1_SYSREG_PERIC1_PCLK didn't exist and &sysreg_peric1 wasn't in use until this series here anyway. If this patch here gets backported to some older kernel due to the Fixes: tag, without the whole peric1 series, it wouldn't build. Therefore I left it out. Should it still be added? Cheers, Andre'