On Fri, Jan 26, 2024 at 11:16 AM Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
>
> ETIMEDOUT is more specific than EIO, use it for
> wait_for_completion_timeout().
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> ---
Looks like you missed my R-b tag I added to this patch in your
previous submission.
> drivers/spi/spi-s3c64xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 76fa378ab5ab..2f2c4ad35df4 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -526,7 +526,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
>
> /*
> * If the previous xfer was completed within timeout, then
> - * proceed further else return -EIO.
> + * proceed further else return -ETIMEDOUT.
> * DmaTx returns after simply writing data in the FIFO,
> * w/o waiting for real transmission on the bus to finish.
> * DmaRx returns only after Dma read data from FIFO which
> @@ -547,7 +547,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
>
> /* If timed out while checking rx/tx status return error */
> if (!val)
> - return -EIO;
> + return -ETIMEDOUT;
>
> return 0;
> }
> @@ -577,7 +577,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
> if (use_irq) {
> val = msecs_to_jiffies(ms);
> if (!wait_for_completion_timeout(&sdd->xfer_completion, val))
> - return -EIO;
> + return -ETIMEDOUT;
> }
>
> val = msecs_to_loops(ms);
> --
> 2.43.0.429.g432eaa2c6b-goog
>
