Hi Tudor, On Tue, Jan 23, 2024 at 03:34:04PM +0000, Tudor Ambarus wrote: > The driver uses GENMASK() but does not include <linux/bits.h>. > Include the missing header, we shall aim to have the drivers self > contained. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> > --- > drivers/spi/spi-s3c64xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index b350e70fd179..9ce56aa792ed 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -3,6 +3,7 @@ > // Copyright (c) 2009 Samsung Electronics Co., Ltd. > // Jaswinder Singh <jassi.brar@xxxxxxxxxxx> > > +#include <linux/bits.h> I don't see why this should be included. Are there cases when not having bits.h produces any compilation error? Andi > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/dma-mapping.h> > -- > 2.43.0.429.g432eaa2c6b-goog >
