On 21/12/2023 19:29, Mark Hasemeyer wrote: >> You do not need this property, if driver assumes that. Just enable it >> unconditionally. > > The goal of this patch series is to change exactly that: to prevent > the driver from unconditionally enabling the irq for wake. But why? What is the problem being solved? Is unconditional wakeup in the driver incorrect? If so, mention it shortly in the commit msg, what is rationale because existing one does not justify this change. > The driver works across numerous buses (spi, uart, i2c, lpc) and > supports DT and ACPI. > SPI+DT systems all happen to need irq wake enabled. > >> I don't think anything from previous discussion was >> resolved. > > Which previous discussion do you mean? In v1 it was suggested to split https://lore.kernel.org/all/20231213221124.GB2115075-robh@xxxxxxxxxx/ Best regards, Krzysztof
