On 12/14/23 13:19, Krzysztof Kozlowski wrote: > On 14/12/2023 13:08, Arnd Bergmann wrote: Hi, Arnd, Krzysztof, Thanks for the review! >> On Thu, Dec 14, 2023, at 11:52, Tudor Ambarus wrote: >>> Sync the defconfig with savedefconfig as config options >>> change/move over time. >>> >>> Generated with the following commands: >>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig >>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- savedefconfig >>> cp defconfig arch/arm64/configs/defconfig > These are obvious. You cannot do it differently. This was just a prerequisite patch for the next, where I made a config builtin. Modifying defconfig shall be made in a similar manner, but it seems it's not the case (144 line change here), and that's why I considered it is worth specifying how I did it. > >>> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> >>> --- >>> arch/arm64/configs/defconfig | 144 +++++++++++++---------------------- >>> 1 file changed, 55 insertions(+), 89 deletions(-) >> I usually ask for defconfig changes to be merged when someone just >> adds a single line per patch, but a 144 line change is clearly too >> big, please split this up. The truth is I didn't think we care what configs get removed after a savedefconfig. I see now after Arnd's review that we have a higher goal and savedefconfig shall be used to identify misconfiguration. > Anyway this should not go via my tree, because of possible conflicts. > This commit, so the savedefconfig, must be prepared on linux-next, which > should be mentioned in changelog for example. It also is not related to > this patchset. Please ignore this patch. Cheers, ta
