On 02/12/2023 02:54, Sam Protsenko wrote:
> On Fri, Dec 1, 2023 at 10:11 AM Peter Griffin <peter.griffin@xxxxxxxxxx> wrote:
>>
>> Google gs101 SoC is ARMv8 mobile SoC found in the Pixel 6,
>> (oriole) Pixel 6a (bluejay) and Pixel 6 pro (raven) mobile
>> phones. It features:
>> * 4xA55 little cluster
>> * 2xA76 Mid cluster
>> * 2xX1 Big cluster
>>
>> This commit adds the basic device tree for gs101 (SoC).
>> Further platform support will be added over time.
>>
>> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
>> ---
...
>> +
>> + watchdog_cl0: watchdog@10060000 {
>> + compatible = "google,gs101-wdt";
>> + reg = <0x10060000 0x100>;
>> + interrupts = <GIC_SPI 765 IRQ_TYPE_LEVEL_HIGH 0>;
>> + clocks =
>> + <&cmu_misc CLK_GOUT_MISC_WDT_CLUSTER0_IPCLKPORT_PCLK>,
>> + <&ext_24_5m>;
>> + clock-names = "watchdog", "watchdog_src";
>> + samsung,syscon-phandle = <&pmu_system_controller>;
>> + samsung,cluster-index = <0>;
>> + status = "disabled";
>> + };
>
> Krzysztof, can you please advice which scheme is preferred right now:
> sorting by name or by address? I saw your patch for dts style doc, but
> just want to know the current state of affairs.
Use coding style, so sorting by unit address in DTSI and by
label/phandle of overrides in DTS.
Coding style was not yet applied, but I don't see any objections to it
so it is just a matter of days.
Best regards,
Krzysztof
