On Sun, Nov 12, 2023 at 08:48:49AM +0100, Krzysztof Kozlowski wrote: > On 10/11/2023 16:30, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is ignored (apart > > from emitting a warning) and this typically results in resource leaks. > > > > To improve here there is a quest to make the remove callback return > > void. In the first step of this quest all drivers are converted to > > .remove_new(), which already returns void. Eventually after all drivers > > are converted, .remove_new() will be renamed to .remove(). > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > Maybe let's trim the commit msg? Or convert all drivers at once if you > want to drop long explanation... I like the verbosity of the commit log. This way you have a chance to understand its motivation by only looking at that single commit. IMHO doing one commit per driver is also right: It simplifies review, allows me to send patches to only the respective maintainers and so annoy less, the people reviewing the changes can send a tag for the driver change they look at only. But I'm not religious about that and if Greg wants to squash the patches together that's ok for me. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
