Hi Guenter, Thanks for your review. On Wed, 11 Oct 2023 at 00:56, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Tue, Oct 10, 2023 at 11:49:23PM +0100, Peter Griffin wrote: > > This patch adds the compatibles and drvdata for the Google > > gs101 & gs201 SoCs found in Pixel 6 and Pixel 7 phones. Similar > > to Exynos850 it has two watchdog instances, one for each cluster > > and has some control bits in PMU registers. > > > > The watchdog IP found in gs101 SoCs also supports a few > > additional bits/features in the WTCON register which we add > > support for and an additional register detailed below. > > > > dbgack-mask - Enables masking WDT interrupt and reset request > > according to asserted DBGACK input > > > > windowed-mode - Enabled Windowed watchdog mode > > > > Windowed watchdog mode also has an additional register WTMINCNT. > > If windowed watchdog is enabled and you reload WTCNT when the > > value is greater than WTMINCNT, it prompts interrupt or reset > > request as if the watchdog time has expired. > > I am a bit lost with this one. The patch adds QUIRK_HAS_WTMINCNT_REG > but doesn't use it. It also adds S3C2410_WTMINCNT but does not use it > either. > > What is the point of doing that ? It is just confusing. Good spot, it seems I lost a few hunks from this patch at some point, sorry about that. I will update and send a v3. regards, Peter.
