Re: [PATCH v5 11/17] qcom_minidump: Register ramoops region with minidump

Mukesh Ojha <quic_mojha@xxxxxxxxxxx> · Mon, 11 Sep 2023 13:28:57 +0530

On 9/11/2023 11:31 AM, Pavan Kondeti wrote:
On Sun, Sep 10, 2023 at 01:46:12AM +0530, Mukesh Ojha wrote:
Register all the pstore frontend with minidump, so that they can
be dumped as default Linux minidump region to be collected on
SoC where minidump is enabled.

Helper functions is written in separate file and built along with
the minidump driver, since it is client of minidump and also call
it at appropriate place from minidump probe so that they always
get registered.

While at it also rename the out minidump module object name during
build as qcom_apss_minidump which basically depicts as Qualcomm
Application processor subsystem minidump.

Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>
---
  drivers/soc/qcom/Kconfig                 |  1 +
  drivers/soc/qcom/Makefile                |  3 +-
  drivers/soc/qcom/qcom_minidump.c         |  4 ++
  drivers/soc/qcom/qcom_ramoops_minidump.c | 88 ++++++++++++++++++++++++++++++++
  drivers/soc/qcom/qcom_ramoops_minidump.h | 10 ++++
  5 files changed, 105 insertions(+), 1 deletion(-)
  create mode 100644 drivers/soc/qcom/qcom_ramoops_minidump.c
  create mode 100644 drivers/soc/qcom/qcom_ramoops_minidump.h

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 4b36d46807bc..b3977f1687d8 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -305,6 +305,7 @@ config QCOM_MINIDUMP
  	tristate "QCOM APSS Minidump driver"
  	depends on ARCH_QCOM || COMPILE_TEST
  	depends on QCOM_SMEM
+	depends on PSTORE

Can't we make QC minidump available without PSTORE? PSTORE is another
cllient for minidump, so other clients can still use minidump right?
Where is this hard dependency coming from?

Thanks for asking this question, this was intentionally put here to
continue the discussion forward about minidump existence in kernel tree
and how community want to see it in kernel tree.

Actually, there is no hard dependency of minidump on pstore and  as i 
have said in cover-letter about minidump is going to collect what 
ramoops is offering now or going to offer in future as a default
regions.

So, main minidump driver does not depends on pstore since, i have 
integrated even the minidump client with this
qcom_ramoops_minidump_{register|unregister}()

I may guard this entire qcom_ramoops_minidump_{register|unregister}()
function under CONFIG_PSTORE_RAM, if everyone agree ?

-Mukesh

Thanks,
Pavan






