Hi Yue, On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote: > commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind > s3c_i2c(*)_set_platdata(). > commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") > leave s5p_i2c_hdmiphy_set_platdata() declaration. > And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h") > leave s3c_i2c(*)_cfg_gpio() alone. I don't understand anything from the commit message here. How about: " After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes have become unused. Remove them. [*] 0d297df03890 ("ARM: s3c: simplify platform code") d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h") " > Signed-off-by: Yue Haibing <yuehaibing@xxxxxxxxxx> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> which branch should this go? Samsung or i2c? Andi