On 17/07/2023 13:26, Jaewon Kim wrote: > > On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote: >> On 17/07/2023 11:42, Jaewon Kim wrote: >>> Add samsung,exynosautov9-pwm compatible string to binding document. >>> >>> Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ >>> 1 file changed, 10 insertions(+), 6 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> index fe603fb1b2cc..6f65e2b52f52 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> @@ -20,12 +20,16 @@ description: |+ >>> >>> properties: >>> compatible: >>> - enum: >>> - - samsung,s3c2410-pwm # 16-bit, S3C24xx >>> - - samsung,s3c6400-pwm # 32-bit, S3C64xx >>> - - samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> - - samsung,exynos4210-pwm # 32-bit, Exynos >>> + oneOf: >>> + - const: samsung,s3c2410-pwm # 16-bit >>> + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx >>> + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> + - const: samsung,exynos4210-pwm # 32-bit, Exynos >> These are still an enum. > Okay I will change const to enum. >> >>> + - items: >>> + - enum: >>> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 >> Let's drop the comment? > > Should I just delete this comment or delete all comments in the > enum(16-bit,S3C24xx, .....). No, the other can stay. Here it is redundant, since Autov9 is obvious - comes from compatible - and rest is coming from compatibility with older models. Best regards, Krzysztof
