On Sat, Jun 10, 2023 at 07:10:15PM +0200, Andi Shyti wrote: > All errors are unlikely and if it's unlikely, why there is no > unlikely(!rate)? The likely/unlikely() annotations help performance at the expense of readability. If they improved readability every if statement would have them. They should only be used if it makes a difference in a benchmark. I think I have heard other people say the rule is that they shouldn't be used in the drivers/ directory. Also the other thing to consider is that quite often GCC is clever enough to figure out which paths are success paths and which are failure paths. So sometimes adding the annotation is redundant. regards, dan carpenter
