On Mon, May 15, 2023 at 04:32:00PM +0900, Inki Dae wrote: > Hi, > > 2023년 5월 8일 (월) 오전 1:27, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>님이 작성: > > > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is (mostly) ignored > > and this typically results in resource leaks. To improve here there is a > > quest to make the remove callback return void. In the first step of this > > quest all drivers are converted to .remove_new() which already returns > > void. > > > > Trivially convert the exynos drm drivers from always returning zero in > > the remove callback to the void returning variant. > > Could you please update exynos_drm_vidi.c also? Seems you missed. This one cannot be trivially converted as vidi_remove() doensn't return zero in all cases. I didn't grok the details about ctx->raw_edid and don't know if skipping component_del() is right or not. If you know the driver, feel free to address this. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
