On 19/04/2023 11:45, Jaewon Kim wrote:
>>> static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
>>> - struct spi_transfer *xfer)
>>> + struct spi_transfer *xfer, int use_irq)
>>> {
>>> void __iomem *regs = sdd->regs;
>>> unsigned long val;
>>> + unsigned long time;
>>> u32 status;
>>> int loops;
>>> u32 cpy_len;
>>> @@ -563,17 +568,24 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
>>> int ms;
>>> u32 tx_time;
>>>
>>> - /* sleep during signal transfer time */
>>> - status = readl(regs + S3C64XX_SPI_STATUS);
>>> - if (RX_FIFO_LVL(status, sdd) < xfer->len) {
>>> - tx_time = (xfer->len * 8 * 1000 * 1000) / sdd->cur_speed;
>>> - usleep_range(tx_time / 2, tx_time);
>>> - }
>> You just added this code. Adding and immediately removing it, suggests
>> this should be one patch.
>>
> This code has been moved, not removed.
Move consists of remove and add. Add it in correct place since beginning.
Best regards,
Krzysztof
