On 13/03/2023 14:55, Mark Brown wrote: > On Fri, Mar 10, 2023 at 11:28:42PM +0100, Krzysztof Kozlowski wrote: >> The driver can match only via the DT table so the table should be always >> used and the of_match_ptr does not have any sense (this also allows ACPI >> matching via PRP0001, even though it is not relevant here). >> >> drivers/spi/spi-armada-3700.c:807:34: error: ‘a3700_spi_dt_ids’ defined but not used [-Werror=unused-const-variable=] > > It would be much better to fix of_match_ptr() and/or the module stuff > that also references the match table here. Why? The recommendation is in general not to use of_match_ptr, because there are little benefits but it disables matching via PRP0001. Jonathan in parallel thread explicitly said of_match_ptr should disappear and he is not accepting any new code with it. And in general he is right. https://lore.kernel.org/all/20230311183534.1d0dfd64@jic23-huawei/ and earlier: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=444f5f854b35 Best regards, Krzysztof
