On Sat, Mar 04, 2023 at 08:56:53AM -0800, Guenter Roeck wrote: > Use devm_add_action_or_reset() to disable the watchdog when the driver > is removed to simplify the code. With this in place, we can use > devm_watchdog_register_device() to register the watchdog, and the removal > function is no longer necessary. While the cleanup in this driver is good ( Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> ) I wonder if disabling the watchdog at .remove() is right. At least there is an inconsistency among watchdog drivers if the hardware is supposed to stop or not. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
