On Mon, Feb 27, 2023 at 08:41:22PM +0100, Marek Vasut wrote: > > If we go ahead with no need for DRM-managed helper at the moment, then > > find the panel hook in host.attach and then drop 2/18. > > The panel lookup must happen in .bind/.probe for exynos/imx respectively , > that's really all that is required here. Then you can drop 1,2,3/18 and get > this series applied (I hope) . > > Can you implement just this one change ? > > There is no need to use drmm_* helper for now, that can be improved later if > possible. Yeah... The drmm helper isn't needed per se, but not using it will create a use-after-free pattern that is very easy to miss. I'd really prefer not to add a new helper that favors an unsafe pattern, but the driver seems to have a whole bunch of them anyway so it's not really a big deal. Which also raises another question: if it's code that is only really relevant in the context of that driver, why are you creating a helper for it in the first place? It would be much easier to just have that code in your driver: there's no need to consider all cases, document it properly, you can have as many workarounds as possible, etc. Maxime
Attachment:
signature.asc
Description: PGP signature
