Re: [PATCH v13 12/18] drm: exynos: dsi: Consolidate component and bridge

[Marek Vasut <marex@xxxxxxx>]

On 2/27/23 12:39, Jagan Teki wrote:

[...]

> @@ -1733,11 +1728,67 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>   	return 0;
>   }
>   
> +static int _exynos_dsi_host_attach(struct exynos_dsi *dsim,

I didn't notice it before, but please get rid of those leading 
underscores in function names, they shouldn't be necessary.

> +				   struct mipi_dsi_device *device)
> +{
> +	struct exynos_dsi_enc *dsi_enc = dsim->priv;

[...]