On Sat, Feb 11, 2023 at 08:32:48AM -0800, srinivas pandruvada wrote: > On Sat, 2023-02-11 at 08:53 +0100, Daniel Lezcano wrote: > > On 11/02/2023 03:10, Ricardo Neri wrote: > > > On Mon, Feb 06, 2023 at 04:34:29PM +0100, Daniel Lezcano wrote: > > > > As the name states "thermal_core.h" is the header file for the > > > > core > > > > components of the thermal framework. > > > > > > > > Too many drivers are including it. Hopefully the recent cleanups > > > > helped to self encapsulate the code a bit more and prevented the > > > > drivers to need this header. > > > > > > > > Remove this inclusion in every place where it is possible. > > > > > > > > Some other drivers did a confusion with the core header and the > > > > one > > > > exported in linux/thermal.h. They include the former instead of > > > > the > > > > latter. The changes also fix this. > > > > > > > > The tegra/soctherm driver still remains as it uses an internal > > > > function which need to be replaced. > > > > > > > > The Intel HFI driver uses the netlink internal framework core and > > > > should be changed to prevent to deal with the internals. > > > > > > I don't see any of the thermal netlink functionality exposed. Is > > > there any work in progress? > > > > commit bd30cdfd9bd73b68e4977ce7c5540aa7b14c25cd > > Author: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > > > > thermal: intel: hfi: Notify user space for HFI events > > > This is already exposed and we use it in user space. > thermal_genl_cpu_capability_event() is called from intel_hfi driver to > send the cpu capabilities. > > Not sure what do you mean by "don't see netlink functionality > exposed"? > > thermal_genl_cpu_caps struct and thermal_genl_cpu_capability_event() > are defined in drivers/thermal/thermal_netlink.h. Yes, I mean exactly this. The HFI code uses this functionality, but it is declared in "../thermal_netlink.h". I just wondered if that is OK or also needs to be declared somewhere in include/linux/ Thanks and BR, Ricardo
