Hi Daniel, daniel.lezcano@xxxxxxxxxx wrote on Mon, 6 Feb 2023 16:34:29 +0100: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > > Remove this inclusion in every place where it is possible. > > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > > No functional changes > > [ Applies to thermal/linux-next or linux-pm/linux-next ] > > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > --- > drivers/thermal/amlogic_thermal.c | 1 - > drivers/thermal/armada_thermal.c | 2 -- For armada_thermal.c: Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > drivers/thermal/broadcom/bcm2835_thermal.c | 1 - > drivers/thermal/hisi_thermal.c | 3 +-- > drivers/thermal/imx8mm_thermal.c | 1 - > drivers/thermal/imx_sc_thermal.c | 1 - > drivers/thermal/intel/intel_hfi.c | 3 ++- > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 - > drivers/thermal/qoriq_thermal.c | 1 - > drivers/thermal/rcar_gen3_thermal.c | 1 - > drivers/thermal/samsung/exynos_tmu.c | 3 +-- > drivers/thermal/st/stm_thermal.c | 1 - > drivers/thermal/tegra/tegra30-tsensor.c | 1 - > drivers/thermal/uniphier_thermal.c | 2 -- > 14 files changed, 4 insertions(+), 18 deletions(-) > > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c > index d30cb791e63c..9235fda4ec1e 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -28,7 +28,6 @@ > #include <linux/regmap.h> > #include <linux/thermal.h> > > -#include "thermal_core.h" > #include "thermal_hwmon.h" > > #define TSENSOR_CFG_REG1 0x4 Thanks, Miquèl
