On Wed, 18 Jan 2023 19:44:11 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in
> examples.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> index 6c5ad426a016..12f75ddc4a70 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> @@ -42,7 +42,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - heart_mon@0 {
> + heart-rate@0 {
These are both heart-rate and pulse oximeters so measure more than just
the rate (oxygen saturation in the blood). Reality is they actually
measure light absorption over time, but you can calculate an estimate
of both rate and oxygen saturation from that.
I don't really mind simplifying that to heart-rate, but wanted to
call this out for possible discussion.
> compatible = "ti,afe4403";
> reg = <0>;
> spi-max-frequency = <10000000>;
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> index c0e815d9999e..b334f3e356ad 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> @@ -39,7 +39,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - heart_mon@58 {
> + heart-rate@58 {
> compatible = "ti,afe4404";
> reg = <0x58>;
> tx-supply = <&vbat>;
The rest are all fine. If no one comments I'll pick this up as it is in a few
days.
Jonathan
