Hi Xiu >-----Original Message----- >From: Xiu Jianfeng [mailto:xiujianfeng@xxxxxxxxxx] >Sent: Wednesday, November 23, 2022 8:50 AM >To: krzysztof.kozlowski@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; >tomasz.figa@xxxxxxxxx; cw00.choi@xxxxxxxxxxx; >alim.akhtar@xxxxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; >dianders@xxxxxxxxxxxx; yadi.brar@xxxxxxxxxxx; mturquette@xxxxxxxxxx >Cc: linux-samsung-soc@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx >Subject: [PATCH] clk: samsung: Fix memory leak in >_samsung_clk_register_pll() > >If clk_register() fails, @pll->rate_table may have allocated memory by >kmemdup(), so it needs to be freed, otherwise will cause memory leak issue, >this patch fixes it. > >Fixes: 3ff6e0d8d64d ("clk: samsung: Add support to register rate_table for >samsung plls") >Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> >--- Thanks! Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > drivers/clk/samsung/clk-pll.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index >fe383471c5f0..0ff28938943f 100644 >--- a/drivers/clk/samsung/clk-pll.c >+++ b/drivers/clk/samsung/clk-pll.c >@@ -1583,6 +1583,7 @@ static void __init _samsung_clk_register_pll(struct >samsung_clk_provider *ctx, > if (ret) { > pr_err("%s: failed to register pll clock %s : %d\n", > __func__, pll_clk->name, ret); >+ kfree(pll->rate_table); > kfree(pll); > return; > } >-- >2.17.1
