On 08/11/2022 22:37, Marek Szyprowski wrote: > of_device_get_match_data() function should not be used on the device > other than the one matched to the given driver, because it always returns > the match_data of the matched driver. In case of exynos-clkout driver, > the code matched the OF IDs on the PARENT device, so replacing it with > of_device_get_match_data() broke the driver. > > This reverts commit 777aaf3d1daf793461269b49c063aca1cee06a44. This was untested, automated commit and there were several other like that from Minghao. Other driver owners should check if they have the same issue. I made a quick look and seems fine, but it all depends what was the of_device_get_match_data() argument. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Please add Cc-stable tag. Do reverts need a Fixes tag? I guess as well... > --- > drivers/clk/samsung/clk-exynos-clkout.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Best regards, Krzysztof
