> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx] > Sent: 07 November 2022 14:42 > To: chanho61.park@xxxxxxxxxxx; Inbaraj E <inbaraj.e@xxxxxxxxxxx>; > Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>; tomasz.figa@xxxxxxxxx; > Chanwoo Choi <cw00.choi@xxxxxxxxxxx>; ALIM AKHTAR > <alim.akhtar@xxxxxxxxxxx>; mturquette@xxxxxxxxxxxx; > sboyd@xxxxxxxxxx; robh+dt@xxxxxxxxxx > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; PANKAJ KUMAR DUBEY > <pankaj.dubey@xxxxxxxxxxx> > Subject: Re: [PATCH] dt-bindings: clock: exynosautov9: fix reference to > CMU_FSYS1 mmc card clock > > On 07/11/2022 01:04, CHANHO PARK wrote: > >>> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of > dout. > >>> > >>> This fixes make dtbs_check warning as shown below: > >>> > >>> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock- > >> controller@17040000: > >>> clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected From > schema: > >>> /home/inbaraj/mainline/linux/Documentation/devicetree/ > >>> bindings/clock/samsung,exynosautov9-clock.yaml > >> > >> I don't understand: > >> 1. Why bindings are wrong not DTSI? > >> 2. What is "gout"? "dout" had a meaning as clock divider output. > > > > "gout" is output of a gate clock, AFAIK. > > Unlike any other clocks, the fsys1 mmc top clock does not have a divider. > So, it should be "mout -> gout" instead of "mout -> gout -> dout". > > OK, then this should be in commit msg. > > My question about full legal name remains, as here in replies I see "Inbaraj > E". > I have address your review comment, and posted v2. Thanks for review. > Best regards, > Krzysztof
